Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add source maps to esm build #761

Closed
Balearica opened this issue May 16, 2023 · 2 comments
Closed

Add source maps to esm build #761

Balearica opened this issue May 16, 2023 · 2 comments

Comments

@Balearica
Copy link
Collaborator

The .min.js build includes source maps but the .esm.min.js build does not. These should be added.
Balearica added a commit that referenced this issue May 16, 2023
@Balearica
Added source maps to esm build per #761
f0a6c08
@Balearica
Copy link
Collaborator Author

Unfortunately, simply adding sourcemap: true to rollup.esm.mjs did not work. Adding the rollup-plugin-sourcemaps did resolve, however this package unfortunately is not maintained so this dependency may cause issues in the future. Along with the fact that the ESM build uses rollup while the others do not, I would prefer a different solution for the ESM build if one presents itself.

Had to use this workaround due to rollup-plugin-sourcemaps specifying old versions:
maxdavidson/rollup-plugin-sourcemaps#125 (comment)

@Balearica Balearica mentioned this issue May 16, 2023
Closed
Balearica added a commit that referenced this issue May 16, 2023
@Balearica
Added source maps to esm build per #761
869b720
Balearica added a commit that referenced this issue May 16, 2023
@Balearica
Added source maps to esm build per #761 (#763)
5b5edbb
@Balearica
Copy link
Collaborator Author

Resolved by #763.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added source maps to esm build per #761 naptha/tesseract.js
1 participant
@Balearica