Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Chrome Extension Manifest V3 Example to README.md #782

Merged
merged 1 commit into from Jun 13, 2023

Conversation

Tshetrim
Copy link
Contributor

Added a third chrome extension example that is compatible with Manifest v3. All of the current examples only use manifest v2.

The extension also takes advantage of Tesseract JS language support and allows users to switch between all 100+ of them.

Added a third chrome extension example that is compatible with Manifest v3, the all of the current examples only use manifest v2. 

The extension also takes advantage of Tesseract JS language support and allows users to switch between all of them.
@Tshetrim Tshetrim changed the title Update README.md Add Chrome Extension Manifest V3 Example to README.md Jun 13, 2023
@Balearica
Copy link
Collaborator

Is there any reason to keep the manifest v2 examples or should those be deleted? I am not familiar with browser extension development.

@Tshetrim
Copy link
Contributor Author

https://developer.chrome.com/docs/extensions/mv2/

Yup - there is no reason to keep manifest v2 anymore. Chrome officially no longer accepts projects that still use manifest v2 (see link above). The benefit I see is some of the code being useful, but the issue is a direct port from manifest v2->v3 isn't exactly possible (see issue below) and honestly, the API Docs and other examples are good enough to cover it.

#601

@Balearica Balearica merged commit 5a0a330 into naptha:master Jun 13, 2023
6 checks passed
@Balearica
Copy link
Collaborator

Thanks for confirming, I will delete the old repos for manifest v2 from the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants